Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2474R2 views::repeat #5709

Merged
merged 1 commit into from Aug 17, 2022
Merged

P2474R2 views::repeat #5709

merged 1 commit into from Aug 17, 2022

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer added this to the post-2022-07 milestone Aug 5, 2022
@jensmaurer
Copy link
Member Author

Note: This fails the automatic build, because [range.repeat.view] Apply modifications from P2494R2
refers to range.move.wrap, which is being renamed from range.copy.wrap by P2494R2, to be applied by #5710.

JohelEGP
JohelEGP suggested changes Aug 5, 2022
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP suggested changes Aug 5, 2022
View reviewed changes
source/ranges.tex Show resolved Hide resolved
JohelEGP
JohelEGP suggested changes Aug 5, 2022
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer force-pushed the motions-2022-07-lwg-29 branch 3 times, most recently from ec4c888 to 5878410 Compare August 5, 2022 21:06
hewillk
hewillk reviewed Aug 6, 2022
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
hewillk
hewillk reviewed Aug 6, 2022
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
@tkoeppe tkoeppe force-pushed the motions-2022-07-lwg-29 branch 2 times, most recently from 84b33cd to 9433456 Compare August 17, 2022 15:05
@JohelEGP
Copy link
Contributor

The commit linked by #5709 (comment) was related to #5710, right?

From https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2494r2.html:

Additionally, this paper proposes to modify the changes in P2474 in this same way. If both this paper and P2474 are accepted, we should make views::repeat have the same constraints as views::single.

Then it has 5. Modifications to P2474.

It seems these were reverted and need to be redone.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 17, 2022

Yes yes: it's not reverted, just not on this branch anymore. I still have the commit :-)

@jensmaurer @tkoeppe
P2474R2 views::repeat
7786c6b 
Editorial changes:
* [range.repeat.iterator] Fix incomplete template-head
* [range.repeat.iterator] Fix misspelled names:
  - "is-signed-like" => "is-signed-integer-like"
  - "bound_" => "current_"
* [range.repeat.iterator] Use statement form of "Equivalent to"
@tkoeppe tkoeppe merged commit 57ccd5c into main Aug 17, 2022
@jensmaurer jensmaurer deleted the motions-2022-07-lwg-29 branch November 18, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@JohelEGP JohelEGP JohelEGP requested changes

@hewillk hewillk hewillk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2022-07
Development

Successfully merging this pull request may close these issues.

[2022-07 LWG Motion 29] P2474R2 views::repeat P2474 views::repeat
4 participants
@jensmaurer @JohelEGP @tkoeppe @hewillk