New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2494R2 Relaxing range adaptors to allow for move only types #5710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly missing spaces to align // \expos
.
75f6712
to
8ca5607
Compare
8ca5607
to
8a7ee6c
Compare
@jensmaurer, @JohelEGP: Several changes to the nested iterator types of the views don't seem to be in the paper, but I take it that's an error in the paper? |
If you mean that an updated template-head of a range adaptor is not reflected in the template-head of the class synopsis of an inner class (template), then you're right. |
But the changes in this PR already takes account for those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paper fails to account for the use of copyable-box
in [range.chunk.by.view]. I believe simply changing its use to movable-box
, as done with filter_view
, will suffice.
Right, I saw that, and wanted to make sure that was deliberate. I'll mention this in the commit message. Thanks! |
Editorial changes: * template-heads have also been updated in the synopses of member class templates.
This change wasn't requested by P2494R2, but is necessary.
8a7ee6c
to
d5aea28
Compare
constexpr explicit repeat_view(const W& value, Bound bound = Bound()) | ||
requires @\libconcept{copy_constructible}@<W>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corresponding change is missing in its detailed specifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll fix it later
@@ -13302,7 +13302,7 @@ | |||
requires @\libconcept{view}@<V> && is_object_v<Pred> | |||
class chunk_by_view : public view_interface<chunk_by_view<V, Pred>> { | |||
V @\exposid{base_}@ = V(); // \expos | |||
@\exposid{copyable-box}@<Pred> @\exposid{pred_}@ = Pred(); // \expos | |||
@\exposid{movable-box}@<Pred> @\exposid{pred_}@ = Pred(); // \expos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A space is needed before the comment to keep them aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix!
Fixes #5617
Fixes cplusplus/papers#1156