Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1642R11 Freestanding Library: Easy [utilities], [ranges], and [iterators] #5713

Merged
merged 2 commits into from Aug 15, 2022
Merged

P1642R11 Freestanding Library: Easy [utilities], [ranges], and [iterators] #5713

merged 2 commits into from Aug 15, 2022

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Aug 6, 2022 •
edited by jensmaurer

@burblebee burblebee marked this pull request as ready for review August 6, 2022 05:38
@burblebee burblebee marked this pull request as draft August 6, 2022 05:40
@burblebee burblebee force-pushed the motions-2022-07-lwg-9 branch 4 times, most recently from 8cc1d2b to e3b35f7 Compare August 6, 2022 06:54
@burblebee
Copy link
Contributor Author

The build is failing with
Overfull \vbox (1.47272pt too high) has occurred while \output is active The error goes away if you delete the iterators.tex line 461:
template<class E> constexpr const E* data(initializer_list<E> il) noexcept; // freestanding
This line seems harmless to me. What's wrong here?

@burblebee burblebee marked this pull request as ready for review August 6, 2022 07:04
JohelEGP
JohelEGP suggested changes Aug 6, 2022
View reviewed changes
source/lib-intro.tex Outdated Show resolved Hide resolved
source/memory.tex Outdated Show resolved Hide resolved
source/memory.tex Outdated Show resolved Hide resolved
source/memory.tex Outdated Show resolved Hide resolved
source/memory.tex Outdated Show resolved Hide resolved
source/iterators.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/threads.tex Outdated Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
source/support.tex Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Aug 6, 2022
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Aug 6, 2022
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Aug 7, 2022
View reviewed changes
source/lib-intro.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@JohelEGP
Copy link
Contributor

JohelEGP commented Aug 7, 2022

The application of the suggestion at #5713 (comment) is still missing.

This was referenced Aug 8, 2022
Open
Closed
Merged
Closed
Closed
@tkoeppe tkoeppe force-pushed the motions-2022-07-lwg-9 branch 4 times, most recently from 9d205c6 to 7d707ea Compare August 14, 2022 22:32
@tkoeppe tkoeppe merged commit bb20277 into main Aug 15, 2022
@JohelEGP
Copy link
Contributor

JohelEGP commented Aug 15, 2022 •
edited

Also resolves cplusplus/papers#429.

@jensmaurer jensmaurer changed the title P1642R11 Freestanding Library: Easy [utilities], [ranges], and [itera… P1642R11 Freestanding Library: Easy [utilities], [ranges], and [iterators] Aug 15, 2022
This was referenced Sep 15, 2022
Closed
Closed
@jensmaurer jensmaurer deleted the motions-2022-07-lwg-9 branch November 18, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely left review comments

@tkoeppe tkoeppe tkoeppe left review comments

@JohelEGP JohelEGP JohelEGP requested changes

@jensmaurer jensmaurer jensmaurer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@burblebee @JohelEGP @jwakely @tkoeppe @jensmaurer