Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpp.predefined] Use of "an" broadens condition too much #5715

Closed
JohelEGP opened this issue Aug 7, 2022 · 3 comments · Fixed by #5988
Closed

[cpp.predefined] Use of "an" broadens condition too much #5715

JohelEGP opened this issue Aug 7, 2022 · 3 comments · Fixed by #5988

Comments

@JohelEGP
Copy link
Contributor

JohelEGP commented Aug 7, 2022

Originating comment: #5670 (comment).

  • STDCPP_BFLOAT16_T
    Defined as the integer literal 1 if and only if the implementation supports an extended floating-point type with the properties described in [basic.extended.fp].

The use of "an" suggests that if any other "extended floating-point type with the properties described in [basic.extended.fp]" other than std::float16_t is defined by the implementation, then __STDCPP_BFLOAT16_T__ should be defined to 1 even if std::float16_t isn't.
@JohelEGP JohelEGP mentioned this issue Aug 7, 2022
Merged
@dkolsen-pgi
Copy link
Contributor

You are right. I'm not sure how I messed that one up. There must have been some context that got lost when the wording was moved to [cpp.predefined].

I suggest:

Defined as the integer literal 1 if and only if the implementation supports an extended floating-point type with the properties of the typedef-name std::bfloat16_t as described in [basic.extended.fp].

@JohelEGP JohelEGP changed the title [cpp.predefined] Use of "an" broads condition too much [cpp.predefined] Use of "an" broadens condition too much Aug 7, 2022
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 7, 2022

@jensmaurer Do you consider fixing that editorial or would you prefer CWG/EWG oversight?

@jensmaurer
Copy link
Member

This looks editorial to me.

@wg21bot wg21bot mentioned this issue Nov 3, 2022
Closed
@jensmaurer jensmaurer mentioned this issue Nov 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Motions 2022 11 cwg 4] Issues 2615, 2639, 2640, 2652, and 2653 from P2710R0 cplusplus/draft
4 participants
@tkoeppe @JohelEGP @jensmaurer @dkolsen-pgi