Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighted code for drafts #572

Closed
shivshankardayal opened this issue Nov 28, 2015 · 11 comments
Closed

Syntax highlighted code for drafts #572

shivshankardayal opened this issue Nov 28, 2015 · 11 comments

Comments

@shivshankardayal
Copy link

I would like to see syntax highlighted code in draft. Thus, I propose to make changes in draft which I can do. I know that it may not be acceptable for some reasons but with git we can have a branch which contains that version of draft.

@sigfpe
Copy link

sigfpe commented Nov 28, 2015

What purpose would this serve?-------- Original message --------From: Shiv Shankar Dayal notifications@github.com Date: 11/27/2015 9:00 PM (GMT-08:00) To: cplusplus/draft draft@noreply.github.com Subject: [draft] Syntax highlighted code for drafts (#572)
I would like to see syntax highlighted code in draft. Thus, I propose to make changes in draft which I can do. I know that it may not be acceptable for some reasons but with git we can have a branch which contains that version of draft.


Reply to this email directly or view it on GitHub.

@shivshankardayal
Copy link
Author

For many people who read drafts on screen it is just pleasing to have it. There is no useful technical value. To keep it separate we can keep it in a separate branch.

@sigfpe
Copy link

sigfpe commented Nov 28, 2015

And many find it a distraction from both the normative spec and the main points sample codes are meant to convey :-)
Given that highlighting taste differs among people, and this is additional work, who is going to maintain this separate branch?-------- Original message --------From: Shiv Shankar Dayal notifications@github.com Date: 11/27/2015 10:35 PM (GMT-08:00) To: cplusplus/draft draft@noreply.github.com Cc: sigfpe sig.fpe@axiomatics.org Subject: Re: [draft] Syntax highlighted code for drafts (#572)
For many people who read drafts on screen it is just pleasing to have it. There is no useful technical value. To keep it separate we can keep it in a separate branch.


Reply to this email directly or view it on GitHub.

@shivshankardayal
Copy link
Author

There is not much of maintenance work. An automated script can do it and we can have a git hook to automatically update branch and generate the pdfs once master is updated. I can maintain this separate branch although I doubt that manual work will be needed frequently.

@sigfpe
Copy link

sigfpe commented Nov 28, 2015

So it can be done in a separate fork?-------- Original message --------From: Shiv Shankar Dayal notifications@github.com Date: 11/27/2015 11:25 PM (GMT-08:00) To: cplusplus/draft draft@noreply.github.com Cc: sigfpe sig.fpe@axiomatics.org Subject: Re: [draft] Syntax highlighted code for drafts (#572)
There is not much of maintenance work. An automated script can do it and we can have a git hook to automatically update branch and generate the pdfs once master is updated. I can maintain this separate branch although I doubt that manual work will be needed frequently.


Reply to this email directly or view it on GitHub.

@shivshankardayal
Copy link
Author

Yes, it can be done in a separate fork.

@sigfpe
Copy link

sigfpe commented Nov 28, 2015

In that case, is it necessary to create an issue against the draft?-------- Original message --------From: Shiv Shankar Dayal notifications@github.com Date: 11/27/2015 11:28 PM (GMT-08:00) To: cplusplus/draft draft@noreply.github.com Cc: sigfpe sig.fpe@axiomatics.org Subject: Re: [draft] Syntax highlighted code for drafts (#572)
Yes, it can be done in a separate fork.


Reply to this email directly or view it on GitHub.

@shivshankardayal
Copy link
Author

I was wondering if that branch could be part of this repository that is why I created this issue. I cannot label it else I would have labeled it tiny or cosmetic.

@jwakely
Copy link
Member

jwakely commented Nov 28, 2015

I am firmly opposed to having ongoing branches or forks of the draft in the official repo, I think it can only lead to confusion. Short-lived branches for making changes that get merged back is fine, but branches for "the draft with syntax highlighting" or "the draft with extra examples" or anything like that would be counter-productive. Such things don't belong in this repo.

@shivshankardayal
Copy link
Author

That is fine. I understand your point. I can create a fork and keep it in my respository where stray users will find it. :)

@zygoloid
Copy link
Member

zygoloid commented Dec 1, 2015

It's likely that this is possible just by changing the configuration of the listings package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants