Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat map assorted editorial improvements #5726

Open
tkoeppe opened this issue Aug 14, 2022 · 7 comments
Open

Flat map assorted editorial improvements #5726

tkoeppe opened this issue Aug 14, 2022 · 7 comments

Comments

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 14, 2022

See #5626 for remaining, unaddressed suggestions.

@jwakely, @CaseyCarter ^^^

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Aug 14, 2022

We should consider styling the "exposition-only" members of flat*_map as \exposid.

@JohelEGP
Copy link
Contributor

We should consider styling the "exposition-only" members of flat*_map as \exposid.

Please, see #5696 (comment).

@JohelEGP
Copy link
Contributor

Might #5626 (comment) and #5626 (comment) need a LWG issue? Those deduction guides are useless. So changing that might not classify as editorial.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Aug 14, 2022

Might #5626 (comment) and #5626 (comment) need a LWG issue? Those deduction guides are useless. So changing that might not classify as editorial.

I certainly want to hear from the LWG chair about this before moving further.

@JohelEGP
Copy link
Contributor

JohelEGP commented Aug 14, 2022

Here's some refactoring for simpler wording.
-- #5626 (review)

https://github.com/cplusplus/draft/pull/5626/files#r922759807: What is range? e.first might be ill-formed.

#5626 (comment): Inconsistent handling of unmet complexity guarantees.

#5626 (comment) should be harmonized with #5626 (comment).

#5626 (comment): C is not an iterator.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Sep 7, 2022

@jwakely Could you please take a look at those "useless deduction guides" above?

@JohelEGP
Copy link
Contributor

JohelEGP commented Sep 7, 2022

I opened #5800 just for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants