Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdspan.mdspan] Remaining uses of pointer #5727

Closed
cpplearner opened this issue Aug 14, 2022 · 2 comments
Closed

[mdspan.mdspan] Remaining uses of pointer #5727

cpplearner opened this issue Aug 14, 2022 · 2 comments

Comments

@cpplearner
Copy link
Contributor

These uses of pointer should be replaced by data_handle_type, as proposed in P2604R0, but it appears that the changes were lost due to merge conflict.

draft/source/containers.tex

Lines 18761 to 18770 in 1bc895c

template<class... OtherIndexTypes>
constexpr explicit mdspan(pointer ptr, OtherIndexTypes... exts);
template<class OtherIndexType, size_t N>
constexpr explicit(N != rank_dynamic()) mdspan(pointer p, span<OtherIndexType, N> exts);
template<class OtherIndexType, size_t N>
constexpr explicit(N != rank_dynamic())
mdspan(pointer p, const array<OtherIndexType, N>& exts);
constexpr mdspan(pointer p, const extents_type& ext);
constexpr mdspan(pointer p, const mapping_type& m);
constexpr mdspan(pointer p, const mapping_type& m, const accessor_type& a);

draft/source/containers.tex

Lines 18931 to 18932 in 1bc895c

template<class... OtherIndexTypes>
constexpr explicit mdspan(pointer p, OtherIndexTypes... exts);

draft/source/containers.tex

Lines 18976 to 18981 in 1bc895c

template<class OtherIndexType, size_t N>
constexpr explicit(N != rank_dynamic())
mdspan(pointer p, span<OtherIndexType, N> exts);
template<class OtherIndexType, size_t N>
constexpr explicit(N != rank_dynamic())
mdspan(pointer p, const array<OtherIndexType, N>& exts);

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 14, 2022

Thanks, I'll fix that!

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 20, 2022

Fixed by e244453.

@tkoeppe tkoeppe closed this as completed Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkoeppe @cpplearner