New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[range.cartesian.view] Fix _cartesian-product-is-common
_
#5735
Comments
I think you're right, will send a PR. |
Is this really correct? From the original paper:
In my opinion this should be template <class First/*, class... Vs*/>
concept cartesian-product-is-common = // exposition only
cartesian-product-common-arg<First>; |
Then I'd also question why the |
|
@griwes: ^^^ (This was the original issue.) |
The reason why common-arg isn't used directly in the constraint is that it's a "lower level" helper concept that's also used elsewhere, whereas is-common is a "higher level" helper concept that's used specifically for answering the question, "is a cartesian product of all of these ranges a common range?". That's also why it takes all the ranges as arguments, instead of just the first one. |
What is
Const
? Why isVs...
unused? The refined concept only takes 1 argument.Presumably,
Const
came from a copy-pastedmaybe-const
<Const, First>
. That'd explain the extra closing>
.Considering the name of the concept and how it's used, this should be:
Originally posted by @JohelEGP in #5647 (comment)
The text was updated successfully, but these errors were encountered: