Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ranges.syn] Fix // freestanding comments of under [range.as.rvalue] #5738

Closed
JohelEGP opened this issue Aug 17, 2022 · 2 comments · Fixed by #5742
Closed

[ranges.syn] Fix // freestanding comments of under [range.as.rvalue] #5738

JohelEGP opened this issue Aug 17, 2022 · 2 comments · Fixed by #5742

Comments

@JohelEGP
Copy link
Contributor

#5708 (comment) was not applied and its surrounding // freestanding comments are not aligned with the rest. See the discussion starting at #5698 (comment) as for why the linked suggestion makes sense, besides having been what the paper requested.
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 17, 2022

I've got this already, thanks.

@tkoeppe tkoeppe mentioned this issue Aug 18, 2022
Merged
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 18, 2022

Splitting the alignment and the missing comment and sending a PR for the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ranges.syn] Add missing "freestanding" comment for as_rvalue. tkoeppe/draft
2 participants
@tkoeppe @JohelEGP