Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpp.cond] Missing __has_cpp_attribute(assume) CWG2615 #5740

Closed
cpplearner opened this issue Aug 17, 2022 · 6 comments · Fixed by #5988
Closed

[cpp.cond] Missing __has_cpp_attribute(assume) CWG2615 #5740

cpplearner opened this issue Aug 17, 2022 · 6 comments · Fixed by #5988
Assignees
@jensmaurer
Labels
cwg Issue must be reviewed by CWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.

Comments

@cpplearner
Copy link
Contributor

P1774R8 adds the assumption attribute assume, but does not modify Table 22 "__has_cpp_attribute values" to handle __has_cpp_attribute(assume).

This appears to be an obvious mistake. Can it be fixed editorially?
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 18, 2022

@jensmaurer Has the feature test macro been discussed?

@jensmaurer
Copy link
Member

The change history of the paper says

R5, 2021-12-09: Updated wording (removed feature-test macro, allowed duplicate attributes, added clarifications). Updated and restructured text, expanding semantics section to reflect discussion in EWG and on the WG21 reflectors. Added Peter Dimov’s refcounted smart pointer code example.

I don't remember any discussion about a feature-test macro in CWG, and the CWG minutes don't show any discussion either. I presume everybody assumed __cpp_has_attribute would just magically work.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 18, 2022

Thanks -- I don't have a problem adding it, but there has been pushback on other missing macros being "normative changes that should go through the regular issue process". Maybe we can make this a CWG issue then?

@tkoeppe tkoeppe added the cwg Issue must be reviewed by CWG. label Aug 18, 2022
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 18, 2022

(Please relabel/reassign as you see fit!)

@jensmaurer jensmaurer added the not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking. label Aug 18, 2022
@jensmaurer jensmaurer changed the title [cpp.cond] Missing __has_cpp_attribute(assume) [cpp.cond] Missing __has_cpp_attribute(assume) CWG2615 Aug 25, 2022
@jensmaurer
Copy link
Member

CWG2615

@frederick-vs-ja
Copy link
Contributor

Should have been fixed by #5988 (82c4158).

@jensmaurer jensmaurer mentioned this issue Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
cwg Issue must be reviewed by CWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Motions 2022 11 cwg 4] Issues 2615, 2639, 2640, 2652, and 2653 from P2710R0 cplusplus/draft
4 participants
@tkoeppe @cpplearner @frederick-vs-ja @jensmaurer