[range.as.rvalue.view] Fix curly brace format #5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should this be detected?
|
Before we do all these one by one, could you maybe have a look at the clause as a whole to see if there are other style violations like this?
Can you describe such a check in a way we can run in the check script? |
|
OK, I'll check them one by one.
This might take some thought. |
|
Also fixed inconsistent constraint ordering with synopsis. |
|
@brevzin Could you please take a look? |
|
So this swaps the two constraints to be consistent with the synopsis (oops) and moves the open brace to the start of the previous line? Looks good. |
|
@brevzin Great, thanks! Yes, I wanted to check that that was indeed an error in the paper, and that this fix is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should this be detected?