Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[memory.syn] Add missing "// freestanding" comment to "destroy" #5758

Merged
merged 1 commit into from Aug 22, 2022
Merged

[memory.syn] Add missing "// freestanding" comment to "destroy" #5758

merged 1 commit into from Aug 22, 2022

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Aug 20, 2022

The comment was supposed to be added by P1642R11, but was accidentally
omitted.

Fixes #5731.

@tkoeppe
[memory.syn] Add missing "// freestanding" comment to "destroy"
62e25dc 
The comment was supposed to be added by P1642R11, but was accidentally
omitted.
@tkoeppe
Copy link
Contributor Author

tkoeppe commented Aug 20, 2022

@ben-craig voila

jwakely
jwakely approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches what the incoming paper said to do.

@tkoeppe tkoeppe merged commit d56c583 into cplusplus:main Aug 22, 2022
@tkoeppe tkoeppe deleted the freedestroy branch August 22, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@CaseyCarter CaseyCarter Awaiting requested review from CaseyCarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std::destroy should be marked freestanding
2 participants
@tkoeppe @jwakely