Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[range.as.const.view] Fix constrain order #5760

Merged
merged 1 commit into from Aug 22, 2022

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Aug 20, 2022

Make it consistent with the synopsis.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 22, 2022

I realize we made this change for as_rvalue_view (2f228c5), but on a closer look, I don't think there's any kind of preference in the existing text for either priority. Some view templates start with view, others with input_range, and this isn't the only outlier. (E.g. look at join_view.)

I'd welcome a wider discussion and analysis first before jumping into piecemeal changes. Feel free to reopen with that.

@tkoeppe tkoeppe closed this Aug 22, 2022
@hewillk
Copy link
Contributor Author

hewillk commented Aug 22, 2022

Yep, but this is a fix, the constraint order actually matters, see #5519.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 22, 2022

Oh OK, it was already inconsistent with its own synposis. Sounds good, thanks!

@tkoeppe tkoeppe reopened this Aug 22, 2022
@tkoeppe tkoeppe merged commit 28f49c9 into cplusplus:main Aug 22, 2022
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 22, 2022

@brevzin ^^^ FYI

@hewillk hewillk deleted the main-as-const branch August 22, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants