Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace fixes around punctuators (library) #577

Merged
merged 3 commits into from Dec 8, 2015

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Dec 5, 2015

No description provided.

@tkoeppe tkoeppe force-pushed the space branch 6 times, most recently from e413a85 to 9b9e91c Compare December 7, 2015 14:02
@jwakely
Copy link
Member

jwakely commented Dec 8, 2015

The library parts look good, but not the rest.

@zygoloid has said elsewhere that the core parts of the standard intentionally use a mix of formatting styles to reinforce the point that whitespace (or the choice of class or typename in template parameter lists) has no semantic significance. So changing things to be consistent breaks that intentional inconsistency.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Dec 8, 2015

You mean Issue #430? Hm, that's unfortunate. I can split the library changes out if you like those.

@jwakely
Copy link
Member

jwakely commented Dec 8, 2015

Yes. I'll merge the library parts, but I'm not touching the rest :-)

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Dec 8, 2015

OK, I restricted the branch to only the library changes!

@tkoeppe tkoeppe changed the title Whitespace fixes around punctuators Whitespace fixes around punctuators (library) Dec 8, 2015
@@ -5421,13 +5421,13 @@

\begin{itemdescr}
\pnum
\requires Let \tcode{CT} be \tcode{common_type<unique_ptr<T1, D1>::pointer,}
\requires Let \tcode{CT} be \tcode{common_type<unique_ptr<T1, D1>::pointer},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comma is part of the type and should be in code font.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, this is a manual line break. Fixed.

jwakely added a commit that referenced this pull request Dec 8, 2015
Whitespace fixes around punctuators (library)
@jwakely jwakely merged commit 8f523d3 into cplusplus:master Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants