Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[range.cartesian.view] Fix neglect for parent_ #5770

Closed
wants to merge 7 commits into from

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Aug 22, 2022

This seems editorial bug in the paper.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 22, 2022

@jwakely Does this require an LWG issue?

@tkoeppe tkoeppe added the lwg Issue must be reviewed by LWG. label Aug 22, 2022
@hewillk
Copy link
Contributor Author

hewillk commented Aug 22, 2022

If this is the LWG, there is no way to implement a functional cartesian_view according to the draft until the LWG makes any decisions.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 22, 2022

If this is the LWG, there is no way to implement a functional cartesian_view according to the draft until the LWG makes any decisions.

That may well be so, but is not an editorial concern.

vector also wasn't implementable until C++23, but that also didn't get fixed editorially.

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@jwakely
Copy link
Member

jwakely commented Aug 22, 2022

If this is the LWG, there is no way to implement a functional cartesian_view according to the draft until the LWG makes any decisions.

That's fine. This is not a final standard, there is no great urgency to fix defects in a draft.

Implementors can easily do this without waiting for an LWG decision. It's common that we implement fixes before they make it into the draft.

Although the changes here seem correct, I don't think it's editorial. Please submit an LWG issue instead, thanks!

@tkoeppe tkoeppe added the not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking. label Aug 22, 2022
hewillk and others added 2 commits August 23, 2022 00:47
Co-authored-by: Jonathan Wakely <github@kayari.org>
Co-authored-by: Jonathan Wakely <github@kayari.org>
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 22, 2022

Could you kindly edit the pull request to avoid sounding disparaging of the existing work and the people who have contributed it?

@hewillk hewillk changed the title [range.cartesian.view] Fix complete neglect for parent_ [range.cartesian.view] Fix neglect for parent_ Aug 22, 2022
@hewillk
Copy link
Contributor Author

hewillk commented Aug 22, 2022

@tkoeppe Sorry for the misunderstanding caused by the misuse of words, I will be more careful with words in the future pull.

@jwakely, thanks for the suggestion.
The reason I insist this is an editorial fix is that it was clearly an oversight, and I believe the fix was what the author originally intended. Maybe we can ask the author again about this opinion after he finishes the vacation.

If this is definitely an LWG, I'd like to ask when it would be appropriate to submit it to the LWG, as the C++23 draft hasn't been published yet.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 22, 2022

Much appreciated!

The paper doesn't ultimately "belong" to the author, so even if an author later changes their mind or clarifies something, that cannot just "bypass" the committee approval. So the normal thing to do in that case is to record the desired correction in an LWG issue. Usually those kinds of issues can be processed very fast. In any case the final standard won't be released for many months, and the committee can always approve issues. So there's plenty of time.

It's perfectly normal for large papers to contain errors and have those fixed later on.

@jensmaurer
Copy link
Member

Specifically addressing your question, you should submit an issue to lwgchair now, so that the matter does not get lost.

@hewillk hewillk closed this Aug 23, 2022
@hewillk hewillk deleted the main-cat-bug branch August 23, 2022 05:43
@hewillk hewillk restored the main-cat-bug branch August 23, 2022 05:44
@hewillk hewillk deleted the main-cat-bug branch August 23, 2022 05:45
@hewillk
Copy link
Contributor Author

hewillk commented Aug 23, 2022

Closed and intends to submit LWG for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lwg Issue must be reviewed by LWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants