[flat.*.{syn,erasure}] Change return type of erase_if to member size_type #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type All other containers and container adapters use the member size_type, and the flat maps already did so in the item specification, but not in the synopsis. The current wording follows the approved proposals, but this change seems like an improvement. Suggested by CD review feedback.
jwakely
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
The synopses obviously need to be consistent, and using size_type is consistent with all other containers and with the detailed descriptions for flat maps. I don't think this needs to go via LWG, I can't imagine anybody asking for any other resolution than this.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other containers and container adapters use the member size_type,
and the flat maps already did so in the item specification, but not in
the synopsis.
The current wording follows the approved proposals, but this change
seems like an improvement.
Suggested by CD review.