Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adjacent_view example. #5779

Merged
merged 1 commit into from Aug 23, 2022
Merged

Fix adjacent_view example. #5779

merged 1 commit into from Aug 23, 2022

Conversation

cor3ntin
Copy link
Contributor

adjacent_view always yields tuples, but the example used std::pair.

@cor3ntin
Fix adjacent_view example.
b44432c 
adjacent_view always yields tuples, but the example
used std::pair.
jwakely
jwakely approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the correct comment indentation this just fits on a single line.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 23, 2022

@jwakely And it is correct as is, right? Comment at column 68?

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 23, 2022

@cor3ntin Please prefix commit messages with the affected subclause. (I'll update it this time.)

@tkoeppe tkoeppe merged commit 227c3b2 into cplusplus:main Aug 23, 2022
@jwakely
Copy link
Member

jwakely commented Aug 23, 2022

@jwakely And it is correct as is, right? Comment at column 68?

After the force-push, yes :-)

@hewillk hewillk mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cor3ntin @tkoeppe @jwakely