New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stmt.return], [stmt.return.coroutine] update notes re implicit move #5783
base: main
Are you sure you want to change the base?
Conversation
@jensmaurer: I'd like a core opinion for this, would you have one or could recommend someone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some overall improvement lurking in the shadows for this pull request, but we're not there yet.
source/statements.tex
Outdated
A copy operation associated with a \tcode{return} statement can be elided or | ||
converted to a move operation if an automatic storage duration variable is returned\iref{class.copy.elision}. | ||
The copy operation associated with a \tcode{return} statement can be elided or | ||
converted to a move operation if an implicitly movable entity\iref{class.copy.elision} is returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(yes, pre-existing, but while we're touching this)
It seems unclear whether the "if" applies to just the "converted to a move operation" part or to the entire "can be elised or converted to a move operation".
685d884
to
f4ea250
Compare
@@ -913,6 +913,10 @@ | |||
\item | |||
If the operand is a \grammarterm{braced-init-list} or an expression of non-\keyword{void} type, | |||
\placeholder{S} is \placeholder{p}\tcode{.return_value(}\grammarterm{expr-or-braced-init-list}{}\tcode{)}. | |||
\begin{note} | |||
The overload resolution of \placeholder{S} is affected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/of/inside/?
These notes probably should have been changed when P1825 was adopted.
f4ea250
to
2397ad9
Compare
These notes probably should have been changed when P1825 was adopted.