[flat.set.syn] <flat_set> should include <compare> LWG3774
#5789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
added
the
not-editorial
|
Let's have an LWG issue for visibility. @jwakely ? |
|
I agree it's an obvious mistake in the paper forwarded by LWG, and the fix is obvious too, but as a normative change I think an LWG issue is the right solution. |
frederick-vs-ja
changed the title
<flat_set> should include <compare><flat_set> should include <compare> LWG3774
|
Closing as reported as LWG3774. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::flat_setandstd::flat_multisethave theiroperator<=>'s, so<compare>should be included in the corresponding header.I'm not sure whether this can be treated as editorial, as the inclusion of
<compare>is missing in P1222R4.