Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ranges] Improve examples #5791

Merged
merged 4 commits into from Aug 25, 2022
Merged

[ranges] Improve examples #5791

merged 4 commits into from Aug 25, 2022

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Aug 24, 2022

  1. Use views::istream instead of ranges::istream_view (consistent with [ranges] Use views::meow in examples instead of meow_view #4659).
  2. Remove unnecessary std:: qualification.

@hewillk
Copy link
Contributor Author

hewillk commented Aug 24, 2022

Hmm, how do I make these comments align?

JohelEGP
JohelEGP suggested changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing std:: removes 5 characters. Add 1 space so the comment is aligned to a multiple of 4.

source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
hewillk and others added 3 commits August 25, 2022 01:34
@hewillk @JohelEGP
Update source/ranges.tex
178b094 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
@hewillk @JohelEGP
Update source/ranges.tex
a7f9ddc 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
@hewillk @JohelEGP
Update source/ranges.tex
9357796 
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
@hewillk
Copy link
Contributor Author

hewillk commented Aug 24, 2022

You are my lifesaver, thanks.

jensmaurer
jensmaurer approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tkoeppe tkoeppe requested a review from jwakely August 25, 2022 01:25
@tkoeppe tkoeppe merged commit 426ce8a into cplusplus:main Aug 25, 2022
@hewillk hewillk deleted the main-example branch August 26, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP JohelEGP requested changes

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hewillk @jwakely @JohelEGP @jensmaurer @tkoeppe