[move.sentinel] Remove extraneous "std::" qualification
#5792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
reviewed
Aug 25, 2022
source/iterators.tex
Outdated
| Consequently, an iterator type \tcode{I} that returns \tcode{std::string} | ||
| by value does not model \tcode{\libconcept{indirectly_writable}<I, std::string>}. | ||
| Consequently, an iterator type \tcode{I} that returns \tcode{string} | ||
| by value does not model \tcode{\libconcept{indirectly_writable}<I, string>}. |
There was a problem hiding this comment.
The purpose of the note is to clarify the normative text. Arguably string in this context is less clear than std::string. A clarifying note should be as clear as possible, and we can be more lax about formatting/specification rules in notes. I don't feel strongly about it though.
The other part of this fix looks fine
There was a problem hiding this comment.
Reasonable, thanks for the suggestion.
hewillk
changed the title
std::" qualificationstd::" qualification
jwakely
approved these changes
Aug 25, 2022
|
@jwakely I agree, though given that we're using all the other std-names unqualified here, it's probably clearer to not have one case differ. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.