Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[const.iterators.alias] Rename template parameter It to I #5807

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Sep 3, 2022

This makes them consistent with the template names in the [iterator.synopsis] and consistent with the <iterator> naming style (which basically uses Iterator or I as the template name).

source/iterators.tex Outdated Show resolved Hide resolved
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2022

@jwakely, @CaseyCarter: have you got a general policy that iterator type parameters should be called I? In principle this change looks good, but maybe we can record such conventions somewhere for posterity?

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 13, 2023

@hewillk Please rebase?

@jwakely, @CaseyCarter Ping :-)

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Mar 13, 2023

We're inconsistent across the entire library, I think we use I, It, Iter and Iterator in various places. In Ranges we do consistently use I: constraints clarify the meaning of names so we don't need descriptive placeholders. The traditional class InputIterator becomes input_iterator I in Ranges templates.

EDIT: As the use of concepts expands into the rest of the Library, it's likely that we'll continue this practice of short-and-simple placeholders.

@jwakely
Copy link
Member

jwakely commented Mar 13, 2023

have you got a general policy that iterator type parameters should be called I?

No, but what Casey said.

@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants