Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace typedef declarations with *alias-declaration*s in the library #581

Closed
zygoloid opened this issue Dec 8, 2015 · 11 comments
Closed

Comments

@zygoloid
Copy link
Member

zygoloid commented Dec 8, 2015

In library synopses, it would be better to use _alias-declaration_s rather than typedef declarations as our "house style".

(As discussed with various parties elsewhere.)

@sigfpe
Copy link

sigfpe commented Dec 8, 2015

Amen.-------- Original message --------From: Richard Smith notifications@github.com Date: 12/8/2015 2:54 PM (GMT-08:00) To: cplusplus/draft draft@noreply.github.com Subject: [draft] replace typedef declarations with _alias-declaration_s in
the library (#581)
In library synopses, it would be better to use alias-declarations rather than typedef declarations as our "house style".

(As discussed with various parties elsewhere.)


Reply to this email directly or view it on GitHub.

@AlisdairM
Copy link
Contributor

Is this something we want to do for C++17? It is something I am, personally, keen to see happen, and if we believe this is entirely editorial, I am prepared to do the work of submitting many pull requests between now and Oulu. The main question, once we confirm that we want to proceed, is what granularity should I exercise for a single pull request?

I would want to go fine-grained enough that a single pull request is (relatively) easy to review, but not so fine-grained that it swamps the queue. The obvious granularity would be one clause at a time, as that is one file/request - but I fear that may be a little too big a bite to get right.

There is also the question of whether we should run it past LWG, or whether your previous discussion with various parties gives you confidence to proceed already?

@sigfpe
Copy link

sigfpe commented Apr 12, 2016

Go for it! :-)-------- Original message --------From: Alisdair Meredith notifications@github.com Date: 4/11/2016 4:56 PM (GMT-08:00) To: cplusplus/draft draft@noreply.github.com Cc: sigfpe sig.fpe@axiomatics.org Subject: Re: [cplusplus/draft] replace typedef declarations with
_alias-declaration_s in the library (#581)
Is this something we want to do for C++17? It is something I am, personally, keen to see happen, and if we believe this is entirely editorial, I am prepared to do the work of submitting many pull requests between now and Oulu. The main question, once we confirm that we want to proceed, is what granularity should I exercise for a single pull request?

I would want to go fine-grained enough that a single pull request is (relatively) easy to review, but not so fine-grained that it swamps the queue. The obvious granularity would be one clause at a time, as that is one file/request - but I fear that may be a little too big a bite to get right.

There is also the question of whether we should run it past LWG, or whether your previous discussion with various parties gives you confidence to proceed already?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

@keryell
Copy link

keryell commented Apr 12, 2016

Yes, it looks odd to have all these typedef everywhere...

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 12, 2016

This should probably not be a "series of pull requests", but rather a single incantation of zygoloid's "carefully crafted regex"...

@AlisdairM
Copy link
Contributor

I have not looked into large-scale changes before, but still recommend a granularity of a pull request/file, to avoid getting into a state of every parallel commit possibly creating conflicts to resolve. Also, I have no "carefully crafted regex" but would be happy to review the output of such, and manually highlight/fix any issues that need attention.

@zygoloid
Copy link
Member Author

I've asked mclow and jyasskin for confirmation they're happy with this, but in principle I think this is a positive change and falls within the bounds of editorial discretion.

@jyasskin
Copy link
Contributor

I believe it's editorial (there's no behavioral change, right?) and a good idea.

@mclow
Copy link
Contributor

mclow commented Apr 13, 2016

I have no objection, either.

@AlisdairM
Copy link
Contributor

AlisdairM commented Apr 15, 2016

Confirming for Jeffrey that there is no behavioral change, it is a purely change of 'coding convention' for how we render our classes, in favor of something I think we all believe should be more readable.

@jwakely
Copy link
Member

jwakely commented Jun 8, 2016

Fixed at c8f1863

@jwakely jwakely closed this as completed Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants