[expr] Replace \^ with \caret
#5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I suppose we could add a check, but then again, this is probably so rare that it's not worth the added complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\^produces the circumflex accentˆinstead of the ASCII character^.The
\caretcommand was added after #205 points out that\^produces a bad caret. PR #1902 fixed two uses of\^that were added after #205 got fixed. But another two uses of\^snuck in after that.Given that
\^keeps reoccuring, there's currently no use of the diacriticˆin this document, and there's precedent of redefining\~to mean something other than the diacritic, would it make sense to redefine\^to mean the ASCII letter, or else add a check to prohibit\^?