Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ranges] Use plain font for ranges/view when it is not specified as concept #5819

Closed
wants to merge 4 commits into from

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Sep 8, 2022

This only added \libconcept for the view that appears in the adapters Overview section to make them consistent.
(Adding \libconcept for all view keywords in <ranges> may be debatable)

Only added \libconcept for the view that appears in the Overview section of adapters to make them consistent.
@jwakely
Copy link
Member

jwakely commented Sep 9, 2022

I know we're inconsistent today and we already do this in many places, but I'm a little uneasy about this change.

This is implicitly defining "a view" as "a type which models the view concept", and personally I think "a view" (without the code font) is fine for that informal term. Using code font for the concept itself and for types which model it seems less clear than using code font for the concept alone. You need to read the context more carefully to understand what is meant.

We don't say "a copy_constructible" or "a semiregular" when we mean types that model those concepts.

I would be a little less uneasy if we used "a view type", but I still think "a view" is acceptable for that meaning.

@jwakely
Copy link
Member

jwakely commented Sep 9, 2022

Also, this makes the entry for view in the index of library concepts even more silly. I don't think we need things like "the resulting view is empty" to be indexed as a use of the concept.

@hewillk
Copy link
Contributor Author

hewillk commented Sep 9, 2022

Also, this makes the entry for view in the index of library concepts even more silly. I don't think we need things like "the resulting view is empty" to be indexed as a use of the concept.

This is a persuasive point. So, for consistency, do we need to change all views in the Overview section to text format "view", that is, take the first step to deal with inconsistent view/"view" keywords?

@jensmaurer
Copy link
Member

In my view (sic), it would make sense to use plain font (and no index entry) for the mentions of "view" in the ranges overview sections. Those are largely introductory anyway.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 16, 2022

editorial consensus: do what Jens said ^^^.

@hewillk
Copy link
Contributor Author

hewillk commented Sep 16, 2022

Do I need to make changes directly in this pull or reopen a pull request?

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 16, 2022

If you could just repurpose this PR, that'd be fine!

@hewillk hewillk changed the title [ranges] Add \libconcept for view in Overview [ranges] Use plain font for view whenit is not specified as concept Sep 17, 2022
@hewillk hewillk changed the title [ranges] Use plain font for view whenit is not specified as concept [ranges] Use plain font for view when it is not specified as concept Sep 17, 2022
@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 24, 2022

@jwakely, could you please take a look?

@@ -3986,7 +3986,7 @@

\pnum
Subclause \ref{range.adaptors} defines \term{range adaptors}, which are utilities that transform a
\libconcept{range} into a \libconcept{view} with custom behaviors. These
\libconcept{range} into a view with custom behaviors. These
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want range in code font here? Doesn't the same principle apply?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I should do that. Thanks for the reminder.

@hewillk hewillk changed the title [ranges] Use plain font for view when it is not specified as concept [ranges] Use plain font for ranges/view when it is not specified as concept Sep 25, 2022
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2022

I've rebased this and will commit it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants