New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ranges] Use plain font for ranges/view when it is not specified as concept #5819
Conversation
Only added \libconcept for the view that appears in the Overview section of adapters to make them consistent.
I know we're inconsistent today and we already do this in many places, but I'm a little uneasy about this change. This is implicitly defining "a We don't say "a I would be a little less uneasy if we used "a |
Also, this makes the entry for |
This is a persuasive point. So, for consistency, do we need to change all |
In my view (sic), it would make sense to use plain font (and no index entry) for the mentions of "view" in the ranges overview sections. Those are largely introductory anyway. |
editorial consensus: do what Jens said ^^^. |
Do I need to make changes directly in this pull or reopen a pull request? |
If you could just repurpose this PR, that'd be fine! |
view
in Overview
@jwakely, could you please take a look? |
source/ranges.tex
Outdated
@@ -3986,7 +3986,7 @@ | |||
|
|||
\pnum | |||
Subclause \ref{range.adaptors} defines \term{range adaptors}, which are utilities that transform a | |||
\libconcept{range} into a \libconcept{view} with custom behaviors. These | |||
\libconcept{range} into a view with custom behaviors. These |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want range
in code font here? Doesn't the same principle apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I should do that. Thanks for the reminder.
I've rebased this and will commit it, thank you! |
This only added \libconcept for the
view
that appears in the adapters Overview section to make them consistent.(Adding \libconcept for all
view
keywords in<ranges>
may be debatable)