Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

placeholders::_2 is not indexed #5828

Closed
jwakely opened this issue Sep 14, 2022 · 6 comments · Fixed by #5846
Closed

placeholders::_2 is not indexed #5828

jwakely opened this issue Sep 14, 2022 · 6 comments · Fixed by #5846
Assignees
@jensmaurer

Comments

@jwakely
Copy link
Member

jwakely commented Sep 14, 2022

It appears in the [functional.syn] synopsis, and in [func.bind.isplace] and [func.bind.place].

placeholders::_1 is indexed, but only once, not for the appearance in [func.bind.isplace].
@jensmaurer
Copy link
Member

... and how many of those placeholder type names should we index? Just _1 and _2, or up to _10, because that's the minimum specified in [implimits]?

@jwakely
Copy link
Member Author

jwakely commented Sep 16, 2022

Yeah, I don't know what's right, but it certainly seems weird that we explicitly mention _2 in two places and don't index it at all (and only index one occurrence of _1).

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 16, 2022

How about the 0, 1, many principle? Either we index nothing, or just _1, or everything, and the last option is not feasible?

@jensmaurer
Copy link
Member

Users will see _1, _2, ..._10 in code (not more, because more is not portable), so I think we should index these in case someone seeks help in the standard to find out what this funny stuff is / does. It's just 3 places in total, so 10 x 3 items won't kill the indexer.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 16, 2022

OK, sure!

@jensmaurer jensmaurer self-assigned this Sep 17, 2022
@jensmaurer
Copy link
Member

We don't index appearances in the synopsis separately; we only index the definition.

@jensmaurer jensmaurer mentioned this issue Sep 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[func.bind] Index 10 placeholders jensmaurer/draft
3 participants
@jwakely @tkoeppe @jensmaurer