Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index entries for range adaptors in namespace views #5831

Closed
jwakely opened this issue Sep 14, 2022 · 5 comments
Closed

Index entries for range adaptors in namespace views #5831

jwakely opened this issue Sep 14, 2022 · 5 comments
Labels
decision-required A decision of the editorial group (or the Project Editor) is required.

Comments

@jwakely
Copy link
Member

jwakely commented Sep 14, 2022 •
edited

For other entities in a nested namespace, we just index its name, not its scope. For example, the index contains steady_clock, not chrono|steady_clock, and duration not chrono|duration, and adjacent_view not ranges|adjacent_view.

But then for the range adaptors we have views|adjacent, views|drop etc.

image

Was this a deliberate choice?
@jensmaurer
Copy link
Member

Yes, the choice was deliberate ("drop" is too generic a name), but maybe it's not sufficiently consistent.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Sep 16, 2022
@jensmaurer
Copy link
Member

@tkoeppe , what do you think?

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 16, 2022

First and foremost, the index needs to be useful more than it needs to be consistent. If generic names benefit from context, I can see that being useful. It's not that surprising that durations or clocks have to do with chrono, but for the range adaptors there is otherwise litlte context -- what kind of "chunk" are we talking about?

So the status quo seems fine.

If you really wanted to, you could add the namespace to the "chrono" and "ranges" names, but I'm not sure that would improve the usability of the index. If in doubt, I'd leave it as is.

@jwakely
Copy link
Member Author

jwakely commented Sep 16, 2022

OK, works for me. Feel free to close this.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 16, 2022

Thanks!

@tkoeppe tkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
@jwakely jwakely mentioned this issue Oct 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision-required A decision of the editorial group (or the Project Editor) is required.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwakely @tkoeppe @jensmaurer