[unord.general, container.adaptors.general] Complete the alias template that appears in the reduction guides #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te that appears in the reduction guides This looks like neglect of the [P1206](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1206r7.pdf). Is this an editorial?
|
Yes, I think this clearly follows the intention of the paper. @CaseyCarter, @cor3ntin could you please take a look? |
|
Yes, this looks fine to me, i missed that sentence when producing the wording. |
jensmaurer
requested changes
Sep 16, 2022
|
Note that there are two identical Should the |
jensmaurer
approved these changes
Sep 18, 2022
There was a problem hiding this comment.
I don't understand what this paragraph is supposed to achieve normatively in the first place, but the update looks good to me.
Please make sure to squash and fix the commit description, e.g.
[unord.general, container.adaptors.general] Fix list of exposition-only alias templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like neglect of the P1206. Is this an editorial?