Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expected] Change stable label from "ctor" to "cons", add xref #5845

Merged
merged 1 commit into from Sep 17, 2022

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Sep 16, 2022

No description provided.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Sep 16, 2022

The wiki has been updated to allow both spellings of the label.

@jensmaurer
Copy link
Member

@tkoeppe , the wiki should offer a single option so that future papers / editors know what to use, legacy aside.

@JohelEGP
Copy link
Contributor

Which is the preference? This PR changes from "ctor" to "cons". "cons" was also added to the wiki. If we assume that "ctor" was the preference because it was first on the wiki, this PR going backwards towards legacy.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Sep 16, 2022

@jensmaurer: OK, I'll make it clear that "cons" is more common and preferred.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Sep 16, 2022

@JohelEGP I think "cons" is more common among the C++20 material, so let's use that for new material, too.

@JohelEGP
Copy link
Contributor

JohelEGP commented Sep 16, 2022

It's certainly the more common generally, too:

$ grep rSec * | grep '\.cons]' | wc -l
73
$ grep rSec * | grep '\.ctor]' | wc -l
19

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Sep 17, 2022

@jensmaurer PTAL?

@jensmaurer
Copy link
Member

https://acronyms.thefreedictionary.com/PTAL says

PTAL = Post-Traumatic Activity Level

@tkoeppe tkoeppe merged commit b758eca into cplusplus:main Sep 17, 2022
@tkoeppe tkoeppe deleted the cons branch September 18, 2022 00:15
@AlisdairM
Copy link
Contributor

AlisdairM commented Oct 3, 2022

@JohelEGP I think "cons" is more common among the C++20 material, so let's use that for new material, too.

Sorry, coming late to the conversation.
I would like to suggest that .ctor was the better term, as .cons is a very common prefix when talking about C++:
constructor
constraint
constant
constexpr
constinit
consteval
consume (OK, I am reaching with this one!)

There are several others such as console, consecutive, and consistent that are less likely to be topics for labels.

We should not be using such an ambiguous common prefix as a label where we have idiomatic alternatives.

I will move this to a new issue for discussion if there is interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants