Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ranges] Indexing fixes for iterator and sentinel classes #5849

Merged
merged 1 commit into from Sep 23, 2022

Conversation

jensmaurer
Copy link
Member

Also add automated checks.

Fixes #5832

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 18, 2022

The collation seems to go wrong (e.g. the first entry of the Index of library names is now "is-callable-from"). Maybe we need to remove the markup from the sort order somehow? But it seems ot have already been broken before.

@jensmaurer
Copy link
Member Author

Oh well.

@jensmaurer
Copy link
Member Author

@tkoeppe , do you have a specific example? It doesn't seem to matter in the cases I looked at (e.g. elements_view::iterator / sentinel).

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 19, 2022

I think this is a pre-existing problem, indeed. Let me take a quick look.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 23, 2022

Hm, this requires a separate fix, so it's unrelated to this patch.

@tkoeppe tkoeppe merged commit 177a09b into cplusplus:main Sep 23, 2022
@jensmaurer jensmaurer deleted the c74 branch September 23, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some exposition-only types are not formatted as such in the index
2 participants