Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support, etc.] New subclause "Arithmetic types". #5851

Merged
merged 2 commits into from Sep 21, 2022

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Sep 17, 2022

The new subclause contains both "integer types" () and "extended floating-point types" ().

Previously, the newly added synopsis was somewhat disconnected and out of context.

Fixes #5714.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Sep 17, 2022

We lose both stable lables [cstdint] and [cstdint.general] in the process, which were not used very much at all.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly harmless.

source/lib-intro.tex Outdated Show resolved Hide resolved
The new subclause contains both "integer types" (<cstdint>)
and "extended floating-point types" (<stdfloat>).

Previously, the newly added <stdfloat> synopsis was somewhat
disconnected and out of context.

This change removes the stable labels [cstdint] and [cstdint.general].
Comment on lines 1998 to 2000
\pnum
The header \libheader{stdfloat} defines type aliases for
the optional extended floating-point types\iref{basic.extended.fp}.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwakely, @dkolsen-pgi: I made up this new introductory wordingl could you please have a look if it's OK?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest a slight change:

The header defines type aliases for the optional extended floating-point types with specified formats ([basic.extended.fp]).

or

The header defines type aliases for the optional extended floating-point types that are specified in [basic.extended.fp].

There can be other extended floating-point types beyond those specified in [basic.extended.fp] and [stdfloat.syn]. I want to avoid wording that implies that they are the only extended floating-point types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks, done!

@tkoeppe tkoeppe merged commit db26a63 into cplusplus:main Sep 21, 2022
@tkoeppe tkoeppe deleted the float branch September 21, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subclause [stdfloat.syn] is oddly disconnected
4 participants