Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies with hyphens #5871

Merged
merged 6 commits into from Apr 30, 2023
Merged

Fix inconsistencies with hyphens #5871

merged 6 commits into from Apr 30, 2023

Conversation

tocic
Copy link
Contributor

@tocic tocic commented Sep 28, 2022

@JohelEGP
Copy link
Contributor

multidimensional

That's consistent with __cpp_multidimensional_subscript.

@tkoeppe tkoeppe added the big An issue causing a large set of changes, scattered across most of the text. label Nov 8, 2022
@tocic
Copy link
Contributor Author

tocic commented Apr 6, 2023

I've rebased the PR onto the current main. No new problems have been found in the commits in between.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an improvement.

I'd prefer to structure the commits according to the word being fixed, not according the subclause, though.

@tocic
Copy link
Contributor Author

tocic commented Apr 7, 2023

Do you mean only one commit per word, or just that a commit shouldn't fix multiple words? The former will result in long commit messages, if I need to enumerate all the subclauses. The latter will result in shorter messages, but you still won't be able to review all the changes to one word at a time.

@JohelEGP
Copy link
Contributor

JohelEGP commented Apr 7, 2023

For the former, if there are more than 2-3 subclauses, you can use [std] if it spans multiple Clauses, or refer to parent subclauses rather than the specific subclauses. For example, 7cc17d9, for "subdirectories", can just be [filesystems].

@jensmaurer
Copy link
Member

jensmaurer commented Apr 7, 2023

Thanks, much better. Please add "hyphenation of" after "inconsistent" in each commit message.

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 30, 2023

Thank you for the very tidy commits!

@tkoeppe tkoeppe merged commit e16a651 into cplusplus:main Apr 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big An issue causing a large set of changes, scattered across most of the text.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants