New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistencies with hyphens #5871
Conversation
tocic
commented
Sep 28, 2022
- "cross-reference": dictionary, repo, ngrams
- "multidimensional": dictionary, repo, ngrams
- "well-formed": dictionary, repo, ngrams
- "well-defined": dictionary, repo, ngrams
- "error-prone": dictionary, repo, ngrams
- "subdirectory": dictionary, repo, ngrams
That's consistent with |
I've rebased the PR onto the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an improvement.
I'd prefer to structure the commits according to the word being fixed, not according the subclause, though.
Do you mean only one commit per word, or just that a commit shouldn't fix multiple words? The former will result in long commit messages, if I need to enumerate all the subclauses. The latter will result in shorter messages, but you still won't be able to review all the changes to one word at a time. |
For the former, if there are more than 2-3 subclauses, you can use [std] if it spans multiple Clauses, or refer to parent subclauses rather than the specific subclauses. For example, 7cc17d9, for "subdirectories", can just be [filesystems]. |
Thanks, much better. Please add "hyphenation of" after "inconsistent" in each commit message. |
Thank you for the very tidy commits! |