[macros] Add space into \range, reflow [alg.transform] #588
Conversation
| @@ -234,7 +234,7 @@ | |||
| \newcommand{\mname}[1]{\tcode{\unun\ungap#1\ungap\unun}} | |||
|
|
|||
| %% Ranges | |||
| \newcommand{\Range}[4]{\tcode{#1\brk{}#3,\brk{}#4\brk{}#2}\xspace} | |||
| \newcommand{\Range}[4]{\tcode{#1\brk{}#3, \brk{}#4\brk{}#2}\xspace} | |||
There was a problem hiding this comment.
Please use ~ not here; we don't want line breaks within these.
There was a problem hiding this comment.
I thought \brk{} means "allow linebreak here"? Do you also want to remove those from the macro?
There was a problem hiding this comment.
The change adds some line breaks inside ranges. Here's one example:
tkoeppe
force-pushed
the
range
branch
2 times, most recently
from
155c62a
to
a9e41bf
Compare
|
OK, after some discussion: I think we should allow linebreaks here, but with the hyphenation penalty like we had before (we should prefer to break on a "real" space rather than after the comma). Something like |
tkoeppe
force-pushed
the
range
branch
5 times, most recently
from
b2375c4
to
ef347e3
Compare
|
Changed to just |
|
Note to self: investigate 25.3.4/2. |
|
Added a change to [alg.transform] to look a bit more palatable:
|
tkoeppe
changed the title
| {result + (last1 - first1)}.\footnote{The use of fully | ||
| \begin{itemize} | ||
| \item \crange{first1}{last1}, | ||
| \item \tcode{[first2, first2 + (last1 - first1)]}, and |
There was a problem hiding this comment.
Why is this one not a \crange?
There was a problem hiding this comment.
Left-over from experimenting; reverted to \crange.
tkoeppe
force-pushed
the
range
branch
2 times, most recently
from
6981fac
to
25207eb
Compare
[macros] Add space into \Range, reflow [alg.transform]
The usual typographic convention is to have a space after (but not before) a comma. This change inserts a comma into the
\rangemacro to print ranges as[a, b)rather than the current[a,b).This has about 90 pdfdiffs, all looking like improvements.