Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[class.union.general] Attach example to its note #5882

Merged
merged 3 commits into from Nov 8, 2022

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented Oct 3, 2022

The example relates to the note which relates to the p4's first sentence.

The example relates to the note which relates to the p4's first sentence.
@JohelEGP
Copy link
Contributor Author

JohelEGP commented Oct 3, 2022

The same logic could be applied to p7, which includes a note and example for the very long p6.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2022

@JohelEGP I moved the example into the note that it exemplifies, could you please take a look?

@JohelEGP
Copy link
Contributor Author

JohelEGP commented Nov 8, 2022

I think it looks fine. But I vaguely remember moving away from examples within notes.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2022

I'm not sure about moving away, where did you see that? Even the "typical example" in https://github.com/cplusplus/draft/wiki/Specification-Style-Guidelines#latex-source-code-formatting contains such a nested example.

@JohelEGP
Copy link
Contributor Author

JohelEGP commented Nov 8, 2022

You're right. I'm misremembering. A quick search reveals many such occurrences in the draft.

@tkoeppe tkoeppe merged commit 4c442cf into cplusplus:main Nov 8, 2022
@JohelEGP JohelEGP deleted the class.union.general branch November 8, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants