Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dcl.link] Fix the wording of the application of the specified language linkage #5892

Merged
merged 1 commit into from Nov 8, 2022

Conversation

blackteahamburger
Copy link
Contributor

[dcl.link]/1:

All functions and variables whose names have external linkage and all function types have a language linkage.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2022

@zygoloid Could you have a look?

Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks right to me.

There are cases where a linkage-specification causes a name to have external linkage (either by implying an extern or by causing a declaration to be attached to the global module), so there's some risk of this change introducing ambiguity, but those cases rely on whether the linkage-specification is syntactically present rather than whether a language linkage is applied to the name, so I think this is fine.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2022

OK, thank you!

@tkoeppe tkoeppe merged commit 89269f8 into cplusplus:main Nov 8, 2022
@blackteahamburger blackteahamburger deleted the extern branch January 6, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants