Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vector.bool.pspc] Add a blank line between the private and public members of std::vector<bool>::reference #5896

Merged
merged 6 commits into from Dec 16, 2022

Conversation

blackteahamburger
Copy link
Contributor

No description provided.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2022

This seems rather piecemeal. Similar newlines are missing in other places, even in containers.tex. Could you have a broader look?

@blackteahamburger
Copy link
Contributor Author

This seems rather piecemeal. Similar newlines are missing in other places, even in containers.tex. Could you have a broader look?

I've done some, please help find more.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 12, 2022

Could we maybe have one commit per file, and you can combine label references like [foo.bar, foo.xyz] Tweak vertical whitespace.

@blackteahamburger
Copy link
Contributor Author

Could we maybe have one commit per file, and you can combine label references like [foo.bar, foo.xyz] Tweak vertical whitespace.

OK. But there are so many of them, can I just write like [ranges]?

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 12, 2022

Yes, some deepest common ancestor is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants