Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bunch of ranges) inconsistency about whether *_view::iterator has the class or struct class-key #5901

Open
strega-nil-ms opened this issue Oct 11, 2022 · 5 comments
Open

(bunch of ranges) inconsistency about whether *_view::iterator has the class or struct class-key #5901

strega-nil-ms opened this issue Oct 11, 2022 · 5 comments

Comments

@strega-nil-ms
Copy link

For example, in [range.repeat.view], the repeat_view::iterator member class is declared with the class-key struct. However, in [range.repeat.iterator], repeat_view::iterator is declared with the class-key class.

This is also true for:

The class-keys are consistently struct for:

The others all use class-key class.
@strega-nil-ms strega-nil-ms changed the title (bunch of ranges) inconsistency about whether _*_view::iterator_ has the class or struct _class-key_ (bunch of ranges) inconsistency about whether <i><code>*_view::iterator</code></i> has the class or struct _class-key_ Oct 11, 2022
@strega-nil-ms strega-nil-ms changed the title (bunch of ranges) inconsistency about whether <i><code>*_view::iterator</code></i> has the class or struct _class-key_ (bunch of ranges) inconsistency about whether *_view::iterator has the class or struct _class-key_ Oct 11, 2022
@strega-nil-ms strega-nil-ms changed the title (bunch of ranges) inconsistency about whether *_view::iterator has the class or struct _class-key_ (bunch of ranges) inconsistency about whether *_view::iterator has the class or struct class-key Oct 11, 2022
@JohelEGP
Copy link
Contributor

See #5323.

@strega-nil-ms
Copy link
Author

there is also the inconsistency between ranges, but I think the inconsistency for a specific range is ... well, it's more annoying anyways, given that it's ill-formed.

@jwakely
Copy link
Member

jwakely commented Oct 11, 2022

It's not ill-formed

@strega-nil-ms
Copy link
Author

It's not ill-formed

huh. today I learned, I thought it was, but it's just the MSVC name decoration that changes.

@jwakely
Copy link
Member

jwakely commented Oct 11, 2022

Which is an infamous msvc conformance bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwakely @JohelEGP @strega-nil-ms