Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[range.repeat] The template parameter name W is confusing #5902

Closed
frederick-vs-ja opened this issue Oct 12, 2022 · 2 comments · Fixed by #5903
Closed

[range.repeat] The template parameter name W is confusing #5902

frederick-vs-ja opened this issue Oct 12, 2022 · 2 comments · Fixed by #5903

Comments

@frederick-vs-ja
Copy link
Contributor

Perhaps that name is copied from the specification of iota_view, where W is the initial of weakly_incrementable. However, the first template parameter of repeat_view is entirely unrelated to weakly_incrementable.

I think we should avoid superfluous mirroring of iota_view, and just call the template parameter T.
@CaseyCarter
Copy link
Contributor

FWIW, I agree that this seems like false consistency and we should change it.

@jensmaurer
Copy link
Member

Lots of agreement here. Patch welcome.

@frederick-vs-ja frederick-vs-ja mentioned this issue Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[range.repeat] Change template parameter name W to T frederick-vs-ja/draft
3 participants
@CaseyCarter @frederick-vs-ja @jensmaurer