[range.repeat] Change template parameter name W to T
#5903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide a bit of rationale, and explanation of the status quo? |
Yep. I've added them to the description. |
tkoeppe
added
the
needs rebase
|
@frederick-vs-ja Could you please rebase? |
frederick-vs-ja
force-pushed
the
patch-repeat_view
branch
from
c491374
to
cada4f4
Compare
frederick-vs-ja
force-pushed
the
patch-repeat_view
branch
from
cada4f4
to
4664e59
Compare
|
@tkoeppe OK. I've rebased and force-pushed the branch. |
|
@jwakely, @CaseyCarter Could you please have a look? |
CaseyCarter
approved these changes
Dec 16, 2022
jwakely
approved these changes
Dec 16, 2022
tkoeppe
removed
the
needs rebase
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the first template parameter of
repeat_viewis calledW, which is consistent withiota_view.However, such consistency makes wrong suggestions, because two
W's have totally different constraints. PresumablyWcomes fromweakly_incrementable, which is not related to the first template parameter ofrepeat_view.This PR changes
WtoT, becauseTis a general name for type template parameters, and the constraints ofmove_constructibleare relatively loose. And it also changesWArgstoTArgsfor mirroringBoundArgs. I'm not sure whether the plainArgswould be better.Fixes #5902.