Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[format.arg] remove friend declaration from basic_format_arg::handle #5906

Open
jwakely opened this issue Oct 17, 2022 · 1 comment · May be fixed by #6427
Open

[format.arg] remove friend declaration from basic_format_arg::handle #5906

jwakely opened this issue Oct 17, 2022 · 1 comment · May be fixed by #6427

Comments

@jwakely
Copy link
Member

jwakely commented Oct 17, 2022

That friend declaration says it's for exposition only, but we don't do the same elsewhere (not even in the adjacent subclauses, e.g. basic_format_args needs access to the private data member of format-arg-store).

We should remove the friend declaration.
@jwakely
Copy link
Member Author

jwakely commented Oct 18, 2022

This was left after lwg 3371 removed the other friends.

@frederick-vs-ja frederick-vs-ja linked a pull request Jul 31, 2023 that will close this issue
Open
@Eisenwave Eisenwave mentioned this issue Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jwakely