[container.adaptors] uses_allocator specializations consistently use "Alloc" #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, is there a clear preference? |
Yes: places that require types that qualify as allocators tend to use In the specific case of |
|
Ah, I see. Thank you! Let me take another look. |
tkoeppe
reviewed
Nov 8, 2022
Quuxplusone
force-pushed
the
flatfoo-uses-alloc
branch
2 times, most recently
from
58f21ce
to
9ece2d6
Compare
…"Alloc". This is not intended to trigger (nor un-trigger) any blanket wording; it's purely cosmetic, aligning the parameter names for the flat_foo containers' `uses_allocator` specializations, with the parameter names for stack/queue/priority_queue. Intuitively, `Alloc` is the more appropriate name because this type is not necessarily something that qualifies as an Allocator; it is the same kind of type as the `Alloc` constructor parameters in [queue.defn] for example. My understanding is that the old wording's choice to use `Alloc` in one specialization and `Allocator` in another is _not_ motivated by any intentional difference in semantics between the two specializations; it's just a bit of inconsistency that we can patch up editorially.
Quuxplusone
force-pushed
the
flatfoo-uses-alloc
branch
from
9ece2d6
to
d986698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not intended to trigger (nor un-trigger) any blanket wording; it's purely cosmetic, aligning the parameter names for the flat_foo containers'
uses_allocatorspecializations, with the parameter names for stack/queue/priority_queue.Intuitively,
Allocis the more appropriate name because this type is not necessarily something that qualifies as an Allocator; it is the same kind of type as theAllocconstructor parameters in [queue.defn] for example.My understanding is that the old wording's choice to use
Allocin one specialization andAllocatorin another is not motivated by any intentional difference in semantics between the two specializations; it's just a bit of inconsistency that we can patch up editorially.