[time.format] use basic_ostringstream<charT> instead of ostringstream #5932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I take it that it's an official LWG position that this change is editorial? |
|
I raised it on the reflector, the author of the wording confirmed that my suggested change is correct, nobody objected. I can get the group in Kona to take a poll if you like. |
|
LWG in Kona just agreed this is editorial. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems editorial, because if
charTis notcharthenos_str()cannot be written to the output without widening it, so the current spec isn't implementable. The intention is to use a stringstream to build up the result then write it out, but there's no reason to do that as a narrow string then widen it, so clearly it should be a stringstream of the correct character type. This was confirmed by @vitaut on the LWG reflector, and matches what all implementations do.The hyphenation hint is needed to fix an overfull hbox.