Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atomics] Replace integral and floating-point placeholders #5939

Merged
merged 1 commit into from Nov 17, 2022

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Nov 8, 2022

This resolves NB comment GB-129.

Fixes cplusplus/nbballot#438

@tkoeppe tkoeppe added the ballot-comment Response to an NB or ISO comment on a ballot label Nov 8, 2022
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2022

I'd like to apply the NB resolution merges in one batch, so let's earmark this.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2022

We should think of a suitably uniform commit message, akin to the straw poll commits.

Either something like NB VA-007: [foo.bar] Unindent dedeprecation negation, or maybe as a second paragraph, Fixes NB VA-007, CK-001. We'll discuss in the editorial meeting.

@jwakely
Copy link
Member Author

jwakely commented Nov 9, 2022

N.B. integer-type and floating-point-type match the placeholders in [charconv].

@tkoeppe tkoeppe merged commit fb0df97 into cplusplus:main Nov 17, 2022
@jwakely jwakely deleted the cxx23-gb-129 branch November 17, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ballot-comment Response to an NB or ISO comment on a ballot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GB-129 33.5 [atomics] Avoid "integral" and "floating-point" placeholder in atomic and atomic_ref
2 participants