Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Motions 2022 11 lwg 8] P2704R0 C++ Standard Library Immediate Issues #5982

Merged
merged 14 commits into from Dec 15, 2022
Merged

[Motions 2022 11 lwg 8] P2704R0 C++ Standard Library Immediate Issues #5982

merged 14 commits into from Dec 15, 2022

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 17, 2022 •
edited by jensmaurer

@burblebee burblebee marked this pull request as draft November 17, 2022 06:17
@burblebee burblebee marked this pull request as ready for review November 18, 2022 18:53
JohelEGP
JohelEGP suggested changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LWG3817 LWG3818 LWG3826 are not part of P2704R0. I reviewed them nonetheless.

source/lib-intro.tex Outdated Show resolved Hide resolved
source/xrefdelta.tex Show resolved Hide resolved
timsong-cpp
timsong-cpp reviewed Nov 19, 2022
View reviewed changes
source/lib-intro.tex Outdated Show resolved Hide resolved
@timsong-cpp
Copy link
Contributor

LWG3817 LWG3818 LWG3826 are not part of P2704R0.

They are in the version attached to the wiki. @jwakely - I guess the paper tracking system need to be updated?

@jwakely
Copy link
Member

jwakely commented Nov 20, 2022

Oops yes, I didn't put the latest version on isocpp.org

@jwakely
Copy link
Member

jwakely commented Nov 20, 2022

The document on isocpp.org has been updated to match what we voted on in Kona.

@burblebee
Copy link
Contributor Author

burblebee commented Nov 22, 2022 •
edited

LWG3817 LWG3818 LWG3826 are not part of P2704R0. I reviewed them nonetheless.

What paper are you looking at? They're in the document I'm looking at from the straw polls (https://wiki.edg.com/pub/Wg21kona2022/StrawPolls/p2704r0.html?twiki_redirect_cache=8ee3b437fe2dbe928dd162d653e0e49a).

Oh I see, please update the paper in the straw polls (at https://wiki.edg.com/bin/view/Wg21kona2022/StrawPolls). What's the link to the iosocpp copy?

@JohelEGP
Copy link
Contributor

I used https://wg21.link/P2704R0.

@burblebee
Copy link
Contributor Author

burblebee commented Nov 22, 2022 •
edited

What's supposed to be the "official" paper that we use for the motions? I'm using the ones linked in the strawpolls themselves since my understanding is that that is what was voted on. If that paper was out of date, then the people that voted on the older version may object to having things change out from underneath them.

@tkoeppe what to do here? Should I remove LWG3817 LWG3818 LWG3826 and force-push?

@burblebee
Copy link
Contributor Author

Ok... I think folks are saying that the copy in the strawpolls is the correct one, right? So LWG3817 LWG3818 LWG3826 are supposed to be in.

@jwakely
Copy link
Member

jwakely commented Nov 22, 2022

Ok... I think folks are saying that the copy in the strawpolls is the correct one, right? So LWG3817 LWG3818 LWG3826 are supposed to be in.

Yes. They're in https://wg21.link/P2704R0 now anyway, it's been updated to match the one we voted on.

@burblebee @tkoeppe
LWG3515 §[stacktrace.basic.nonmem]: operator<< should be less templat…
86a1ffc 
…ized
@burblebee @tkoeppe
LWG3569 join_view fails to support ranges of ranges with non-default_…
871cf97 
…initializable iterators
@burblebee @tkoeppe
LWG3717 common_view::end should improve random_access_range case
e38d521 
Partially fixes NB US 109 (C++23 CD).
@burblebee @tkoeppe
LWG3737 take_view::sentinel should provide operator-
7583485 
Partially fixes NB US 109 (C++23 CD).
@burblebee @tkoeppe
LWG3753 Clarify entity vs. freestanding entity
863a4c2 
Fixes NB GB 075 (C++23 CD).
@burblebee @tkoeppe
LWG3766 view_interface::cbegin is underconstrained
abe6947
@burblebee @tkoeppe
LWG3814 Add freestanding items requested by NB comments
d4e29f5 
Fixes NB GB 085, GB 110, (partially) GB 130 (C++23 CD).
@burblebee @tkoeppe
LWG3816 flat_map and flat_multimap should impose sequence container r…
4086402 
…equirements

Fixes NB US 103 (C++23 CD).
@burblebee @tkoeppe
LWG3817 Missing preconditions on forward_list modifiers
10b8762 
Fixes NB GB 101 (C++23 CD).
@burblebee @tkoeppe
LWG3818 Exposition-only concepts are not described in library intro
29aeaf5 
Fixes NB GB 074 (C++23 CD).
@burblebee @tkoeppe
LWG3822 Avoiding normalization in filesystem::weakly_canonical
6163fa7 
Fixes NB US 125 (C++23 CD).
@burblebee @tkoeppe
LWG3823 Unnecessary precondition for is_aggregate
cc63fcd 
Fixes NB GB 090 (C++23 CD).
@burblebee @tkoeppe
LWG3824 Number of bind placeholders is underspecified
a3204c4 
Fixes NB GB 95 (C++23 CD).
@burblebee @tkoeppe
LWG3826 Redundant specification [for overload of yield_value]
60fb503 
Fixes NB US 118 (C++23 CD).
@tkoeppe tkoeppe merged commit ff2298e into main Dec 15, 2022
@tkoeppe tkoeppe deleted the motions-2022-11-lwg-8 branch May 10, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsong-cpp timsong-cpp timsong-cpp left review comments

@jwakely jwakely jwakely approved these changes

@JohelEGP JohelEGP JohelEGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GB-085 20.2.2 [memory.syn] start_lifetime_as and start_lifetime_as_array should be freestanding GB-110 26.2 [ranges.syn] New views should be freestanding (repeat, stride, cartesian_product) GB-095 22.10.15.5 [func.bind.place] Number of bind placeholders is underspecified GB-074 16.3.3 [conventions] Exposition-only concepts are not described in library intro LWG3515 [stacktrace.basic.nonmem]: operator<< should be less templatized
GB-075 16.3.3.6 [freestanding.entity] "Freestanding entities" are not entities GB-090 21.3.5.4 [meta.unary. prop] Unnecessary precondition for is_aggregate GB-101 24.3.9.5p12,15,20,21 [forward.list.modifiers] Missing preconditions on forward_list modifiers FR-006-022 19.6.4.6 [stacktrace.basic.nonmem] Avoid needless templatization US 42-103 24.6.9.1p6 [flat.map.overview] 24.6.10.1p6 [flat.multimap.overview] Clearing when restoring invariants
5 participants
@burblebee @timsong-cpp @jwakely @JohelEGP @tkoeppe