Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Motions 2022 11 cwg 1] P2709R0 ready issues except 2635 and 2602 #5984

Merged
merged 32 commits into from Nov 22, 2022
Merged

[Motions 2022 11 cwg 1] P2709R0 ready issues except 2635 and 2602 #5984

merged 32 commits into from Nov 22, 2022

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 17, 2022 •
edited by jensmaurer

Fixes #5956.

Also fixes #2831.
Also fixes #2854.
Also fixes #5634.
Also fixes #5488.
Also fixes #5129.
Also fixes #5130.
Also fixes #5078.
Fixes cplusplus/papers#1396

@burblebee burblebee marked this pull request as ready for review November 18, 2022 18:26
JohelEGP
JohelEGP suggested changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also resolves #5634.

source/declarations.tex Outdated Show resolved Hide resolved
source/basic.tex Outdated Show resolved Hide resolved
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 19, 2022

@burblebee Is this all done? I'll start squashing and force-pushing then.

@burblebee @tkoeppe
CWG2392 new-expression size check and constant evaluation
cdf92eb
@burblebee @tkoeppe
CWG2407 Missing entry in Annex C for defaulted comparison operators
7d802b4 
[diff.cpp17.over] Restructure new wording to conform to the rest of [diff]
@burblebee @tkoeppe
CWG2410 Implicit calls of immediate functions
99c8605
@burblebee @tkoeppe
CWG2428 Deprecating a concept
a111f0f
@burblebee @tkoeppe
CWG2440 Allocation in core constant expressions
45aadc0
@burblebee @tkoeppe
CWG2451 promise.unhandled_exception() and final suspend point
bcd6e66
@burblebee @tkoeppe
CWG2508 Restrictions on uses of template parameter names
eb43529
@burblebee @tkoeppe
CWG2583 Common initial sequence should consider over-alignment
e04d375
@burblebee @tkoeppe
CWG2590 Underlying type should determine size and alignment requireme…
41506fb 
…nts of an enum
@burblebee @tkoeppe
CWG2598 Unions should not require a non-static data member of literal…
869679a 
… type
@burblebee @tkoeppe
CWG2599 What does initializing a parameter include?
b52fdb0
@burblebee @tkoeppe
CWG2601 Tracking of created and destroyed subobjects
f0f778a
@burblebee @tkoeppe
CWG2603 Holistic functional equivalence for function templates
c8c7011 
[basic.scope.scope] Add reference to "corresponding object parameter" under function template.
[basic.scope.scope] Add missing "their" in new wording.
tkoeppe
tkoeppe reviewed Nov 21, 2022
View reviewed changes
source/statements.tex Outdated Show resolved Hide resolved
tkoeppe
tkoeppe reviewed Nov 21, 2022
View reviewed changes
source/expressions.tex Outdated Show resolved Hide resolved
@tkoeppe tkoeppe self-requested a review November 21, 2022 17:48
tkoeppe
tkoeppe approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@tkoeppe tkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending conclusion of some open discussions.

@tkoeppe tkoeppe mentioned this pull request Nov 21, 2022
Open
@burblebee @tkoeppe
CWG2616 Imprecise restrictions on break and continue
092dec0 
[stmt.pre] Add index to "enclosing" under statement.
@burblebee @tkoeppe
CWG2618 Substitution during deduction should exclude exception specif…
bb4acc8 
…ications
@burblebee @tkoeppe
CWG2619 Kind of initialization for a designated-initializer-list
07b5caa
@burblebee @tkoeppe
CWG2620 Nonsensical disambiguation rule
394a016
@burblebee @tkoeppe
CWG2622 Compounding types from function and pointer-to-member types
2c1f16d
@burblebee @tkoeppe
CWG2624 Array delete expression with no array cookie
fb69b32
@burblebee @tkoeppe
CWG2625 Deletion of pointer to out-of-lifetime object
3f9de47
@burblebee @tkoeppe
CWG2626 Rephrase ones' complement using base-2 representation
68653fc
@burblebee @tkoeppe
CWG2627 Bit-fields and narrowing conversions
acd2c81
@burblebee @tkoeppe
CWG2629 Variables of floating-point type as switch conditions
f8600b8
@burblebee @tkoeppe
CWG2630 Syntactic specification of class completeness
3f33361
@burblebee @tkoeppe
CWG2641 Redundant specification of value category of literals
568c342
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 21, 2022

@jensmaurer Do we need to add a lot of "Also fixes #nbballot" lines to the initial message here?

@burblebee
Copy link
Contributor Author

@jensmaurer Do we need to add a lot of "Also fixes #nbballot" lines to the initial message here?

I'd like to know what we're supposed to do here as well, so I'll know for next time.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 22, 2022

Hm, it seems that neither P2709 nor P2710 are in the paper tracker yet. @jensmaurer: could it be that none of the R0 papers are in the paper tracker, since they haven't been in a mailing yet?

So we don't have to close any draft/papers issue in those cases I suppose. But we still have to close the draft/nbballot issues, right?

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 22, 2022

I have a mapping from NB comment to approved paper and plenary motion in the draft editors' report:

Non-editorial comments

  • FR-004: Partially fixed by P1264R2 (LWG poll 12).
  • FR-009: Duplicate of GB-093
  • FR-019: Duplicate of US-123
  • US-028: Fixed by CWG2640 (CWG poll 4).
  • US-030: Fixed by CWG2639 (CWG poll 4).
  • US-033: Fixed by CWG2242 (CWG poll 3).
  • US-035: Fixed by CWG2642 (CWG poll 3).
  • DE-038: Fixed by P2718R0 (CWG poll 12).
  • US-039: Fixed by CWG2643 (CWG poll 3).
  • US-042: Fixed by CWG2644 (CWG poll 3).
  • US-044: Fixed by CWG2645 (CWG poll 3).
  • US-045: Fixed by CWG2654 (CWG poll 5).
  • US-045: Fixed by CWG2654 (CWG poll 5).
  • DE-046: Fixed by P2564R3 (CWG poll 9).
  • US-047: Fixed by CWG2647 (CWG poll 3).
  • GB-048: Fixed by P2647R1 (CWG poll 8).
  • GB-051: Fixed by CWG2653 (CWG poll 4).
  • US-052: Fixed by CWG2646 (CWG poll 3).
  • CA-054: Fixed by CWG2621 (CWG poll 3).
  • GB-055: Fixed by CWG2538 (CWG poll 6).
  • GB-059: Fixed by P2615R1 (CWG poll 11).
  • US-061: Fixed by P2706R0 (CWG poll 10).
  • CA-063: Fixed by CWG2648 (CWG poll 3).
  • CA-064: Fixed by CWG2649 (CWG poll 3).
  • CA-065: Fixed by P2589R1 (CWG poll 7).
  • US-068: Fixed by CWG2650 (CWG poll 3).
  • US-069: Fixed by CWG2651 (CWG poll 3).
  • GB-070: Fixed by CWG2615 (CWG poll 4).
  • US-071: Fixed by CWG2652 (CWG poll 4).
  • US-073: Fixed by P2167R3 (LWG poll 10).
  • GB-075: Fixed by LWG3753 (LWG poll 8).
  • GB-085: Fixed by LWG3814 (LWG poll 8).
  • US-091: Duplicate of GB-093
  • US-092: Duplicate of GB-093
  • GB-093: Fixed by P2505R5 (LWG poll 13).
  • US-109: Partially fixed by LWG3717 and LWG3737 (LWG poll 8).
  • GB-110: Fixed by LWG3814 (LWG poll 8).
  • US-111: Fixed by P2602R2 (LWG poll 9).
  • US-123: Fixed by P2539R4 (LWG poll 11).
  • US-124: Duplicate of US-123
  • US-125: Fixed by LWG3822 (LWG poll 8).
  • GB-130: Partially fixed by LWG3814 (LWG poll 8).
  • US-132: Fixed by CWG2636 (CWG poll 3).

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 22, 2022

Oh, and of course NB comments are only fixed by P2710, not by P2709, so nothing else to do here! Merging now, thank you everyone!

@tkoeppe tkoeppe merged commit 2764d46 into main Nov 22, 2022
@jensmaurer
Copy link
Member

Hm, it seems that neither P2709 nor P2710 are in the paper tracker yet. @jensmaurer: could it be that none of the R0 papers are in the paper tracker, since they haven't been in a mailing yet?

Yes, exactly.

So we don't have to close any draft/papers issue in those cases I suppose. But we still have to close the draft/nbballot issues, right?

In principle, yes, except CWG motions 1+2 deal with non-NB ready issues only. (All NB-related issues have been suitably annotated.) NB comments are addressed by CWG motions 3+.

This was referenced Mar 2, 2023
Closed
Closed
@tkoeppe tkoeppe deleted the motions-2022-11-cwg-1 branch May 10, 2023 17:48
This was referenced Jul 28, 2023
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe approved these changes

@jensmaurer jensmaurer jensmaurer left review comments

@opensdh opensdh opensdh left review comments

@JohelEGP JohelEGP JohelEGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@burblebee @tkoeppe @jensmaurer @JohelEGP @opensdh