Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Motions 2022 11 cwg 4] Issues 2615, 2639, 2640, 2652, and 2653 from P2710R0 #5988

Merged
merged 5 commits into from Nov 23, 2022
Merged

[Motions 2022 11 cwg 4] Issues 2615, 2639, 2640, 2652, and 2653 from P2710R0 #5988

merged 5 commits into from Nov 23, 2022

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 18, 2022 •
edited by jensmaurer

@burblebee burblebee marked this pull request as ready for review November 18, 2022 18:53
JohelEGP
JohelEGP approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "fixes" comments in the commits should be raised to the OP to actually close issues at https://github.com/cplusplus/nbballot/.
Also resolves #5715.

@tkoeppe tkoeppe merged commit 09e1d93 into main Nov 23, 2022
@tkoeppe tkoeppe deleted the motions-2022-11-cwg-4 branch May 10, 2023 17:49
@frederick-vs-ja frederick-vs-ja mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP JohelEGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@burblebee @JohelEGP @tkoeppe