Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motions 2022 11 lwg 9 #5995

Merged
merged 2 commits into from Dec 15, 2022
Merged

Motions 2022 11 lwg 9 #5995

merged 2 commits into from Dec 15, 2022

Conversation

danra
Copy link
Collaborator

@danra danra commented Nov 21, 2022 •
edited by tkoeppe

P2602R2 Poison Pills are Too Toxic

Fixes #5970.
Also fixes cplusplus/papers#1266.
Also fixes cplusplus/nbballot#526.

Also: Following discussion with @brevzin and @tkoeppe, added an extra note explaining why swap poison pill is still needed.

@tkoeppe tkoeppe requested a review from jwakely November 21, 2022 15:43
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 21, 2022

@jwakely: Could you please take a look at the added note (see second commit)?

jwakely
jwakely approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new note for [concept.swappable] is a good idea. LGTM.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 15, 2022 •
edited

Beautiful, thank you very much, @danra!

And thanks, @JohelEGP, for the review!

@tkoeppe tkoeppe merged commit d8c5f61 into main Dec 15, 2022
@tkoeppe tkoeppe deleted the motions-2022-11-lwg-9 branch May 10, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@JohelEGP JohelEGP JohelEGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@danra @tkoeppe @jwakely @JohelEGP