Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the SI prefixes to the index of library names #6008

Merged
merged 1 commit into from Dec 15, 2022
Merged

Add the SI prefixes to the index of library names #6008

merged 1 commit into from Dec 15, 2022

Conversation

marcmutz
Copy link
Contributor

No description provided.

JohelEGP
JohelEGP suggested changes Nov 28, 2022
View reviewed changes
source/meta.tex Outdated Show resolved Hide resolved
@marcmutz marcmutz force-pushed the add-si-prefixes-to-library-index branch 2 times, most recently from a37bf71 to ce49ccb Compare November 28, 2022 15:12
JohelEGP
JohelEGP reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using \libglobal?

@marcmutz
Copy link
Contributor Author

How about using \libglobal?

Good idea. I have no idea what it's doing, but I see how it's used for ratio_equal_v etc, and I like how it's inline that way. Will update.

@marcmutz marcmutz force-pushed the add-si-prefixes-to-library-index branch from ce49ccb to dde1667 Compare November 28, 2022 15:27
@JohelEGP
Copy link
Contributor

It's not mentioned at https://github.com/cplusplus/draft/wiki/Specification-Style-Guidelines#indexes, but it links to the page of the declaration (or declaration itself on eel.is), rather than the beginning of the synopsis. It also avoids spelling errors.

@marcmutz marcmutz force-pushed the add-si-prefixes-to-library-index branch from dde1667 to eed1479 Compare November 28, 2022 15:29
@tkoeppe tkoeppe merged commit 6539709 into cplusplus:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@JohelEGP JohelEGP JohelEGP approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marcmutz @JohelEGP @jwakely @jensmaurer @tkoeppe