Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iterators] Add missing definitions from the iterators library to the library index #6011

Merged
merged 1 commit into from Dec 16, 2022
Merged

[iterators] Add missing definitions from the iterators library to the library index #6011

merged 1 commit into from Dec 16, 2022

Conversation

Ukilele
Copy link
Contributor

@Ukilele Ukilele commented Dec 8, 2022

Add following definitions from the iterators library to the library index:

  • indirect_result_t
  • iter_common_reference_t
  • iter_const_reference_t
  • iter_reference_t
  • iter_rvalue_reference_t
  • make_const_iterator
  • make_const_sentinel

JohelEGP
JohelEGP suggested changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using \libglobal instead of \indexlibraryglobal should index to the correct page, and raise the confidence by inspection that we're not indexing into a definition that says see below.

@Ukilele
Copy link
Contributor Author

Ukilele commented Dec 8, 2022

Hi @JohelEGP , thanks a lot for your feedback. So is it \libglobal instead of \indexlibraryglobal for all of the definitions that I cover in my PR? I am uncertain, because I think none of the indexes are indexing into a definition that says see below.

@JohelEGP
Copy link
Contributor

JohelEGP commented Dec 8, 2022

So is it \libglobal instead of \indexlibraryglobal for all of the definitions that I cover in my PR?

That's right.

I am uncertain, because I think none of the indexes are indexing into a definition that says see below.

I'd have to manually check if you're right. But if you used \libglobal, any see below would be in the context of the difference, which would make reviewing a breeze.

JohelEGP
JohelEGP suggested changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check out the file to see how \libglobal is used and fix the PR.

@Ukilele
Copy link
Contributor Author

Ukilele commented Dec 8, 2022

Obviously this is my first contribution. I am very thankful for your helpful and especially very quick support, @JohelEGP . Thank you very much!

@JohelEGP
Copy link
Contributor

JohelEGP commented Dec 8, 2022

You can fixup the commits into a single one formatted as described at https://github.com/cplusplus/draft/wiki/Commit-message-format#editorial-commits.

@Ukilele Ukilele force-pushed the add-more-iterator-traits-to-lib-index branch 2 times, most recently from 977dd14 to 6a5dc66 Compare December 9, 2022 19:09
jensmaurer
jensmaurer requested changes Dec 15, 2022
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflicts.

@tkoeppe tkoeppe added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Dec 15, 2022
@Ukilele Ukilele force-pushed the add-more-iterator-traits-to-lib-index branch from 6a5dc66 to 0d96935 Compare December 16, 2022 18:49
@tkoeppe tkoeppe removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Dec 16, 2022
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 16, 2022

@jensmaurer Can you reapprove?

@jensmaurer
Copy link
Member

@tkoeppe, I can.

@tkoeppe tkoeppe merged commit 75f3876 into cplusplus:main Dec 16, 2022
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 16, 2022

Thanks, Jens, esp. for avoiding undefined modal verbs.

@Ukilele Thank you very much for your contribution!

@Ukilele Ukilele deleted the add-more-iterator-traits-to-lib-index branch December 17, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP JohelEGP approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ukilele @JohelEGP @tkoeppe @jensmaurer