Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdspan.mdspan.overview] Add default template parameters for mdspan #6018

Merged
merged 2 commits into from Dec 16, 2022

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Dec 15, 2022

to make it consistent with the declaration.

@jensmaurer
Copy link
Member

jensmaurer commented Dec 16, 2022

Repeated default template arguments are ill-formed.

@hewillk
Copy link
Contributor Author

hewillk commented Dec 16, 2022

Repeated default template parameters are ill-formed.

See #4836.

@jwakely
Copy link
Member

jwakely commented Dec 16, 2022

Identifiers with kebab-case are ill-formed too, but we do that to make things easier to read 🙂

Nobody expects to be able to just copy & paste classes from the standard and use them as-is, so we can repeat the defaults if that makes the specification more clear. And I think it does, because often the synopsis is huge and defaults buried there are not obvious.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good.

@tkoeppe tkoeppe merged commit 405b46f into cplusplus:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants